Skip to content

Fix for code scanning alert no. 1: Insecure randomness #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
feuvan wants to merge 3 commits into
base: main
Choose a base branch
from
+7 −1
Draft

Fix for code scanning alert no. 1: Insecure randomness #11

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f8b26bf
Potential fix for code scanning alert no. 1: Insecure randomness
feuvan Mar 28, 2026
ce38087
Fix insecure randomness using Web Crypto API (browser-compatible)
Copilot Mar 28, 2026
05ae3ea
Refactor: extract randomHex helper to clean up UID generation
Copilot Mar 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/systems/InventorySystem.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,12 @@ import { emptyEquipStats, type EquipStats } from './CombatSystem';
const MAX_INVENTORY = 100;
const MAX_STASH = 80;

function randomHex(bytes: number): string {
return Array.from(globalThis.crypto.getRandomValues(new Uint8Array(bytes)))
.map(b => b.toString(16).padStart(2, '0'))
.join('');
}

export class InventorySystem {
inventory: ItemInstance[] = [];
equipment: Partial<Record<EquipSlot, ItemInstance>> = {};
Expand Down Expand Up @@ -346,7 +352,7 @@ export class InventorySystem {
// Create an inventory item for the gem
const gemBase = getItemBase(gem.gemId);
const gemItem: ItemInstance = {
uid: `gem_${Date.now()}_${Math.random().toString(36).substring(2, 8)}`,
uid: `gem_${Date.now()}_${randomHex(4)}`,
baseId: gem.gemId,
name: gem.name,
quality: 'normal',
Expand Down
Loading