Repository navigation
Improve Instance Types - #69
Open
gaymeowing wants to merge 15 commits into
Open
gaymeowing wants to merge 15 commits into
gaymeowing wants to merge 15 commits into
Conversation
…stead of descending)
Signed-off-by: quaywinn <62822174+gaymeowing@users.noreply.github.com>
* remove hydrate (its just bind) * export is_signal from the instances types.luau (so it can be used in my style sheet wrapper thingy) * make PropertiesFor accept intsersection types, mainly for use with fake generic constraints * make the properties table start off as an actual table, so each property set doesnt have to go through methods * use readindexers instead of indexers on the table types created by PropertiesFor * remove empty table from PropertiesFor * add a type function for getting an array of read only property indexers (this is so my style sheets wrapper branch doesnt have to duplicate the table) * rename first argument of bind to instance because inst is weird
* allow for passing `any` & `unknown` to GetInstance & PropertiesFor
* actually get the type of :Connect() for RBXScriptSignals using an extern type, as it turns out its possible to do in roblox
* allow for providing default properties to PropertiesFor<> via intersections `Frame & { Name: "Divider" }` as a nice alternative to fluid having default properties at runtime
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PropertiesFor<>iePropertiesFor<Frame>any&unknownto GetInstance & PropertiesForget_connectandis_signalPropertiesFor<>via intersections ieFrame & { Name: "Divider" }as a nice alternative to fluid having default properties at runtimealso validates said default properties to ensure they are a subtype of the value of the property on the instance
Closes #64