Feature/fronius gen24 byd - #362
Open
MisterSpliss wants to merge 4 commits into
Open
MisterSpliss wants to merge 4 commits into
MisterSpliss wants to merge 4 commits into
Conversation
Owner
|
Thank you for the substantial work on adding Fronius GEN24 / BYD support. The driver structure, telemetry coverage, ownership switch, translations, documentation, and dedicated unit tests provide a strong foundation. We reviewed PR #362 against its intended target,
The 25 dedicated Fronius unit tests pass, which is a good starting point. Once these issues are addressed and CI is green, we will be happy to review the updated version. Thanks again for contributing Fronius GEN24 / BYD support to Omnibattery. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds Fronius GEN24 with BYD battery support and automatically detects both supported SunSpec register layouts:
floatint+SFThe detected SunSpec model type is shown in the battery driver information panel.
Changes
OutWRteandInWRteregisters.0/0idle power window.StorCtl_Mod; it does not modifyMinRsvPctor the configured power windows.Safety behavior
The default behavior retains external control and places the battery in a closed
0/0idle window during setup, reload, and shutdown.Returning the battery to Fronius automatic control requires an explicit action using the new device switch. This choice is persisted across Home Assistant restarts.
Testing
git diff --checkpassed.