refactor: extract _DelimitedConverter base from DelimitedCollection - #82
refactor: extract _DelimitedConverter base from DelimitedCollection#82msto wants to merge 1 commit into
Conversation
Move the collection_delimiter class variable, the field-classification scan,
and the shared field validator/serializer into a non-exported
_DelimitedConverter base; DelimitedCollection becomes a thin subclass that
carries only the user-facing docstring.
This sets up the single field_serializer("*") on a shared base, which a second
delimited converter can build on without colliding (Pydantic permits only one
serializer per field across the MRO). The base dispatches on the classification
sets directly, so the test-only _is_collection_field predicate is dropped.
Pure refactor; no behavior change.
Relates to #76.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Warning Review limit reached
More reviews will be available in 59 minutes and 59 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@CodeRabbit review |
✅ Action performedReview finished.
|
1 participant
Summary
This PR is the third in a stack to expand
Metric's collection parsing behavior to supporttuple,set, anddictalong with the existinglistsupport, to provide parity with fgpyo.This PR is a pure refactor. It extracts a new
_DelimitedConverterbase class forDelimitedCollectionand the plannedDelimitedMappingmixin (added in the next PR). This was done to share thecollection_delimiterclass variable and field serializer.Related Stack