Skip to content

chore(deps): bump fgumi to 0.7.0 - #28

Merged
nh13 merged 1 commit into
mainfrom
chore/bump-fgumi-0.7.0
Aug 25, 2026
Merged

chore(deps): bump fgumi to 0.7.0#28
nh13 merged 1 commit into
mainfrom
chore/bump-fgumi-0.7.0

Conversation

@nh13

@nh13 nh13 commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

What

Bump fgumi from 0.6.0 to 0.7.0 (crates.io). No mako source change needed beyond the version pin — mako flattens fgumi's Sort clap struct directly, and cargo build is clean against the new API.

Why

fgumi 0.7.0 is the sort-concurrency release. PR fulcrumgenomics/fgumi#846 (five commits) took a canonical WGS template-coordinate sort from 387.1s to ~268s (-31%, ~1.44x) on network-attached storage (EBS gp3), with output staying byte-identical and no increase in thread count. mako inherits this for free from the version bump — no code change required.

Test fix

One test broke: sort_and_count_consolidations (in tests/cli.rs) scrapes the engine's "[N spills]" phase-breakdown log line to read back the spilled-run count. fulcrumgenomics/fgumi#826 moved that entire diagnostics block — previously ~99 lines at info!/debug! — behind a hidden --sort-stats flag, off by default, because most of it was noise for a normal run. The fix passes --sort-stats explicitly in the test helper so the line reappears. The flag doesn't show in mako --help (fgumi marks it hide = true), but it still parses through the flattened Sort struct, so no mako-side wiring is needed.

Verification

cargo ci-fmt, cargo ci-lint, and cargo ci-test all clean; 13 tests pass.

Summary by CodeRabbit

  • Bug Fixes

    • Updated consolidation test behavior to ensure spill statistics continue to be reported and validated correctly.
  • Chores

    • Updated the internal processing dependency to version 0.7.0.

@coderabbitai

coderabbitai Bot commented Aug 25, 2026

Copy link
Copy Markdown

Review Change Stack

Note

Reviews paused

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: de3a4d2a-6a17-4e3f-b40c-9f1ab32207bb

📥 Commits

Reviewing files that changed from the base of the PR and between b975813 and a50fff1.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (2)
  • Cargo.toml
  • tests/cli.rs

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The PR upgrades fgumi from 0.6.0 to 0.7.0. The consolidation test enables --sort-stats so it can continue to parse spill statistics.

Changes

fgumi upgrade

Layer / File(s) Summary
Dependency and test adaptation
Cargo.toml, tests/cli.rs
The dependency uses fgumi 0.7.0. The consolidation test passes --sort-stats and updates its logging comment.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to a50ff

This PR updates the dependency and adjusts one test to enable the dependency’s hidden statistics output; the reported formatting, lint, and test checks pass, so no actionable merge-blocking risk remains.

Poem

A rabbit checks the cargo trail

New fgumi rides the rail
Sort stats bloom in hidden light
Spill counts hop back into sight
Tests thump softly: all is right

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the primary change: updating the fgumi dependency from 0.6.0 to 0.7.0.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (1 skipped: 1 …
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches 💡 1
⚔️ Resolve merge conflicts 💡
  • Resolve merge conflict in branch chore/bump-fgumi-0.7.0
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@nh13

nh13 commented Aug 25, 2026

Copy link
Copy Markdown
Contributor Author

@coderabbitai pause

@coderabbitai

coderabbitai Bot commented Aug 25, 2026

Copy link
Copy Markdown
✅ Action performed

Reviews paused.

fgumi 0.7.0 inherits a sort-side win mako gets for free: PR #846's Phase-1
ingest and read-concurrency work cut a canonical WGS template-coordinate
sort from 387.1s to ~268s (-31%) on network-attached storage, byte-identical
output, no thread-count increase. No mako-side code change is needed to pick
this up.

One test needed updating. PR #826 moved the sort's performance diagnostics
-- including the "[N spills]" phase-breakdown line
`sort_and_count_consolidations` scrapes for the spilled-run count -- behind
a hidden `--sort-stats` flag, off by default. Pass it explicitly so the line
reappears; the flag is not documented in mako's own `--help` since fgumi
marks it hidden, but it still parses through the flattened `Sort` struct.

Verified: cargo ci-fmt, cargo ci-lint, cargo ci-test all clean; 13 tests pass.
@nh13
nh13 force-pushed the chore/bump-fgumi-0.7.0 branch from a50fff1 to 17ac0c6 Compare August 25, 2026 07:57
@nh13
nh13 merged commit 2533da5 into main Aug 25, 2026
9 checks passed
@nh13
nh13 deleted the chore/bump-fgumi-0.7.0 branch August 25, 2026 08:02
@fg-labs-bot fg-labs-bot Bot mentioned this pull request Aug 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant