chore(deps): bump fgumi to 0.7.0 - #28
Conversation
|
Note Reviews pausedUse the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe PR upgrades Changesfgumi upgrade
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This PR updates the dependency and adjusts one test to enable the dependency’s hidden statistics output; the reported formatting, lint, and test checks pass, so no actionable merge-blocking risk remains. Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (1 skipped: 1 unsupported.) ✨ Finishing Touches 💡 1⚔️ Resolve merge conflicts 💡
📝 Generate docstrings
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai pause |
✅ Action performedReviews paused. |
fgumi 0.7.0 inherits a sort-side win mako gets for free: PR #846's Phase-1 ingest and read-concurrency work cut a canonical WGS template-coordinate sort from 387.1s to ~268s (-31%) on network-attached storage, byte-identical output, no thread-count increase. No mako-side code change is needed to pick this up. One test needed updating. PR #826 moved the sort's performance diagnostics -- including the "[N spills]" phase-breakdown line `sort_and_count_consolidations` scrapes for the spilled-run count -- behind a hidden `--sort-stats` flag, off by default. Pass it explicitly so the line reappears; the flag is not documented in mako's own `--help` since fgumi marks it hidden, but it still parses through the flattened `Sort` struct. Verified: cargo ci-fmt, cargo ci-lint, cargo ci-test all clean; 13 tests pass.
a50fff1 to
17ac0c6
Compare
What
Bump
fgumifrom 0.6.0 to 0.7.0 (crates.io). No mako source change needed beyond the version pin — mako flattens fgumi'sSortclap struct directly, andcargo buildis clean against the new API.Why
fgumi 0.7.0 is the sort-concurrency release. PR fulcrumgenomics/fgumi#846 (five commits) took a canonical WGS template-coordinate sort from 387.1s to ~268s (-31%, ~1.44x) on network-attached storage (EBS gp3), with output staying byte-identical and no increase in thread count. mako inherits this for free from the version bump — no code change required.
Test fix
One test broke:
sort_and_count_consolidations(intests/cli.rs) scrapes the engine's"[N spills]"phase-breakdown log line to read back the spilled-run count. fulcrumgenomics/fgumi#826 moved that entire diagnostics block — previously ~99 lines atinfo!/debug!— behind a hidden--sort-statsflag, off by default, because most of it was noise for a normal run. The fix passes--sort-statsexplicitly in the test helper so the line reappears. The flag doesn't show inmako --help(fgumi marks ithide = true), but it still parses through the flattenedSortstruct, so no mako-side wiring is needed.Verification
cargo ci-fmt,cargo ci-lint, andcargo ci-testall clean; 13 tests pass.Summary by CodeRabbit
Bug Fixes
Chores