Skip to content

Avoid oversized cycle detector allocation - #24

Open
JSap0914 wants to merge 1 commit into
fgm:mainfrom
JSap0914:fix-cycle-detector-allocation
Open

Avoid oversized cycle detector allocation#24
JSap0914 wants to merge 1 commit into
fgm:mainfrom
JSap0914:fix-cycle-detector-allocation

Conversation

@JSap0914

@JSap0914 JSap0914 commented Jul 5, 2026

Copy link
Copy Markdown

Summary

  • replace the fixed 1e6-entry call stack buffer in Service with a grow-on-demand runtime.Callers buffer
  • add a regression test that fails when a cache-missing Service call allocates more than 1 MiB

Fixes #19.

Verification

  • go test -run TestContainer_Service_AvoidsOversizedCycleDetectorAllocation -count=1 ./...
  • gopls check izidic.go izidic_test.go
  • git diff --check
  • go test -count=1 ./...

Copilot AI review requested due to automatic review settings July 5, 2026 07:07

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cycle detection: 8 MB allocation per resolution (fixed 1e6 buffer)

2 participants