feat(alertmanager): align receiver schema with Mimir's vendored Alertmanager - #77
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aligns the
mimir_alertmanager_configreceiver schema with the Alertmanager fork Mimir vendors, and makes docs generation actually run in CI.Receiver attributes
Available in every targeted Mimir release:
webhook.timeout,pagerduty.source,pushover.device/ttl,global.smtp_tls_config.Requires Mimir >= 3.1.0, noted as such in each description: discord
content/username/avatar_url; emailforce_implicit_tlsandthreading; pagerdutytimeout; slackapp_token/app_url/message_text/timeout; pushovermonospace; telegrammessage_thread_id; globalsmtp_force_implicit_tls/slack_app_token/slack_app_url/telegram_bot_token;inhibit_rule.name.Mimir rejects a configuration carrying a key it does not know, so every new attribute uses a plain type with
omitemptyand never reaches the wire unless set.TestExpandAlertmanagerConfigOmitsUnsetKeysbuilds each receiver block from the schema itself with zero values and asserts none of the new keys appear, so older Mimir versions stay unaffected.Not added: the
*_filevariants, which Mimir refuses outright, andjira_configs/rocketchat_configs/mattermost_configs/incidentio_configs, which the vendored config parses but for which Mimir builds no notifier — a receiver holding only those gets an empty integrations list and silently drops its alerts.Time intervals
Generated configurations now use
time_intervalsrather than the deprecatedmute_time_intervals. Reads accept either spelling and merge them, so importing a hand-written configuration still works. No Terraform diff for existing users.CI and docs
Adds Mimir 3.1.4 to the acceptance matrix and puts the Mimir version in the job name, with acceptance tests gated on the release that introduced each attribute.
make generatewas a no-op — there was no//go:generatedirective anywhere, so the "Confirm no diff" step passed unconditionally. Adds the directive with an explicit provider name, since tfplugindocs otherwise derives it from the directory basename and produces different output depending on where it runs.