-
Notifications
You must be signed in to change notification settings - Fork 8
d04_d05 small fix #28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can fix as follows:
<<LINE 741>>
K''||{\infty}}{q_l'}
--> K''||{\infty}}{q_{l'}}.
<<LINE 741>>
The output of the \textsf{SlotToCoeff} step is $\textsf{RLWE}{S, \sigma}(M + K''p)$
--> The output of the \textsf{SlotToCoeff} step is $\textsf{RLWE}{S, \sigma}(M + K''p) \bmod q_{l'}$
<<LINE 741>>$||P||_\infty$ denotes the maximum absolute coefficient value of polynomial $P$ ).
where $||P||\infty$ denotes the maximum absolute coefficient value of polynomial $P$).
--> where $\hat{q} < q_l < q{l'} < q_L, and
(a little more details)
<<LINE 637>>$q_l \rightarrow q_l\cdot \hat{q}$ and then a modulus switch from $q_l\cdot \hat{q} \rightarrow \hat{q}$ (based on the technique learned in \autoref{subsec:bgv-modulus-switch})$q_l\cdot \hat{q} \rightarrow \hat{q}$ (based on the technique learned in \autoref{subsec:bgv-modulus-switch})
so that we can do \textsf{ModRaise} from
--> so that we can do a modulus switch from
(we should do a direct modulus swtich from q_l to \hat{q}) as described in \autoref{subsec:bgv-modulus-switch}
<<LINE 417>>
also smaller
--> also small
<<LINE 286>>
$\hat{q}$ only needs to satisfy the relationship: $\hat{q}$ and $q_l$ are co-prime, $\hat{q} < q_l$ and $\hat{q} \equiv 1 \bmod t$ .$\hat{q}$ only needs to satisfy the relationship: $\hat{q} < q_l$ and $\hat{q} \equiv 1 \bmod t$ .
-->
(The co-prime requirement does not make sense here, because \hat{q} is okay to be one of the multiplicative levels of the ciphertext modulus, in which case \hat{q} divides the modulus of the higher multiplicative levels. I think I was trying to say that it's also okay that \hat{q} is co-prime to q_l, which is the case where we do the initial modulus switch from q_l to \hat{q} in the bootstrapping procedure.)
<<LINE 449>>$q_l$ and new ciphertext modulus $\hat{q}$ where $q_l \equiv \hat{q} \equiv 1 \bmod t$ , $\hat{q} < q_l$ , and $\hat{q}$ and $\hat{q_l}$ are co-prime.$q_l$ and new ciphertext modulus $\hat{q}$ where $q_l \equiv \hat{q} \equiv 1 \bmod t$ , and $\hat{q} < q_l$ .
Suppose we have the current ciphertext modulus
--> Suppose we have the current ciphertext modulus
(For the same reason as line 286)