chore: add benchmarks#110
Open
cademirch wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds some benchmarking of ft subcommands in order to understand the (if any) consequences of the future MA library transition. A small helper script downloads the public FIRE test dataset on which the benchmarks are run.
We use criterion to handle the benchmark measuring, repeats, etc.
We only benchmark subcommands that largely touch the "bam_ordered" code path. This is because the handling of this in MA is different than the outgoing Ranges/FiberAnnotations:
on main, FiberAnnotations stores the per-annotation query starts/ends, ref starts/ends, lengths, quals etc as Vecs, computed once at parse time. Importantly, if the molecule is reverse aligned, these vecs are flipped at this time.
In MA, nothing is stored upfront in this way. Rather, we use iter_type on MolecularAnnotations to collect a vec of all annotations of a given type, collect the starts,ends,etc and reverse if needed. The current implementation of this in fibertools-ma branch has this happen for every access and these subcommands hit the accessors multiple times per fiber, so the O(N) reverse on rev-aligned reads adds up fast.