fix(types): match-v5 riotIdGameName - #624
Open
agonyz wants to merge 1 commit into
Open
Conversation
|
Contributor
|
@agonyz apologies l never got notified about this, but let me review and merge in this weekend |
Author
No worries. Thank you :) |
|
@OllieJennings Up! :) |
|
@OllieJennings please approve this PR, we are blocked without you, it's a trivial fix... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
riotIdNamefield does not exist in the Match V5 API response.According to the official Riot Games API documentation, the correct field is
riotIdGameName.This change updates the type definition to match the actual API response.
Official docs: https://developer.riotgames.com/apis#match-v5/GET_getMatchIdsByPUUID