Add Node 24 support (minimal)#19
Open
dmartin-figma wants to merge 10 commits intofigma:figmafrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds Node 24 to the test/release matrix and bumps
@figma/nodegitto0.28.0-figma.10so subsequent tag pushes produce ABI v137 prebuilts (alongside existing 108/115/127).Why
figma/figmais moving to Node 24 (see #768808 in the main monorepo). Cursor agents already run on Node 24 (/opt/cursor-agent/nodeis v24.5.0, ABI v137); the in-monorepo bot-bot CI image also moves to Node 24 with that PR. Both fail today because no v137 prebuilt exists infigma-nodegit.s3.amazonaws.com. This PR unblocks the prebuilt publish.What
update test ssh key+use updated key for tests053e0bff,35596615). Rotates the GH-quarantined SSH key + decodes fromtest/id_rsa.encat runtime so secret scanning doesn't re-flag it. Required for the 3 SSH cred tests to pass.Add Node 24 to build matrixBump C++ standard to C++20 for Node 24+utils/defaultCxxStandard.js: select C++20 whenprocess.versions.modules >= 137. V8 13.x'scppgc/macros.handv8-local-handle.hrequire C++20 features (P0732, requires-clauses).Switch from @axosoft/nan to upstream nan@^2.26.2 for Node 24 V8 API support@axosoft/nan@2.20predates V8 13.x. Upstreamnan@2.26.2includes thev8::Local::GetIsolateandPropertyCallbackInfo::This()deprecation fixes. Updatesbinding.gypinclude path accordingly.Use clang-14 on Linux CI for Node 24 V8 C++20 featurescppgcmacros use.Pin Linux runner to ubuntu-22.04+Bump Linux container to ubuntu:22.04ubuntu-latesthost runner. ubuntu:22.04 ships clang-14 natively, eliminating the need for an extra apt repo.Add explicit constructors to OdbObjectsData inner structs for C++20 aggregate rulesCommitInfo/BlobInfo/TagInfoneed explicit member ctors when paired with user-declared move constructors.Bump to v0.28.0-figma.10Test Plan
v0.28.0-figma.10, verifyfigma-nodegit.s3.amazonaws.com/nodegit-v0.28.0-figma.10-node-v137-{linux-x64,darwin-arm64}.tar.gzpublishedbot-botCI to confirm Node 24 install works end-to-end