Add api error object to exception#52
Open
JohannesHome wants to merge 2 commits intofigo-connect:masterfrom
Open
Add api error object to exception#52JohannesHome wants to merge 2 commits intofigo-connect:masterfrom
JohannesHome wants to merge 2 commits intofigo-connect:masterfrom
Conversation
JohannesHome
commented
Mar 12, 2018
JohannesHome
commented
- Move ErrorObject and ErrorResponse to public model
- Upgrade guava
JohannesHome
commented
Mar 12, 2018
src/main/java/me/figo/FigoApi.java
Outdated
| } | ||
|
|
||
| private void logError(FigoException.ErrorResponse errorResponse, HttpURLConnection connection) { | ||
| private void logError(ErrorResponse errorResponse, HttpURLConnection connection) { |
Author
There was a problem hiding this comment.
I would like to remove this log, but I'm not sure why it was added in the first place. My current workaround is that this logger is blocked by my configuration.
* Move ErrorObject and ErrorResponse to public model * Upgrade guava
JohannesHome
force-pushed
the
add-api-error-to-exception
branch
from
c2ac450 to
c14bada
Compare
…e error information
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.