Repository navigation
Test OpenGL 3.3 runtime in CI - #17
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
--smoke-testmode that creates an OpenGL context, verifies OpenGL 3.3 Core, renders one frame, finishes GPU work, and fails on GL errorsWhy
The existing desktop CI already compiled and linked the OpenGL 3.3 path on Linux, macOS, and Windows, but it did not start the executable. This adds deterministic runtime coverage for context creation, shader/resource initialization, and one rendered frame.
The first PR run also exposed an unrelated pre-existing browser-test flake: under CI load, Monaco dropped different characters from a 19-character synthetic typing stream. The focused test now initializes the prefix through the editor API and sends one real browser keypress, preserving keyboard-isolation coverage without timing sensitivity.
Validation
cmake --build --preset desktop-release --parallelctest --preset desktop-release— 142/142 passed./MeshMakerWebGL2 --smoke-test— passed with an OpenGL 3.3 Core context on NVIDIA 610.57.04cmake --preset webgl && cmake --build --preset webgl --parallel— passed