Repository navigation
fix(roulette): open the daily.dev post when a spared bookmark has no url - #75
Merged
Merged
Conversation
Shares, freeform posts and collections come back from the Public API with url: "" (88 of 274 in a real pile), so "Spare it" opened a blank tab. Fall back to commentsPermalink, which is always set. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 17 minutes. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configuration
📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
share,freeformandcollectioncome back withurl: ""(88 of 274 in a real pile, found while testing the marketplace skill in fix(marketplace): fall back to commentsPermalink and document DELETE quirks in the skill #73). "Spare it" calledwindow.open("")and opened a blank tab.read()now opensurl || commentsPermalink;commentsPermalinkwas set on every bookmark in that pile and opens the post on daily.dev. If neither is set, no tab is opened.Bookmarktype documents the emptyurland addscommentsPermalink; the API route already passes it through unchanged.Test plan
url: ""opens itscommentsPermalink(fails without the fix)pnpm lint,pnpm format:check,pnpm build,pnpm test(28 passed)🤖 Generated with Claude Code