Repository navigation
feat(auth): make the deployed app OAuth-only - #78
Merged
Merged
Conversation
Suggested by the daily.dev team: now that Sign in with daily.dev works, personal API tokens shouldn't pass through a hosted server. - the "paste an API token" form and POST /api/auth only exist under `pnpm dev` (import.meta.env.DEV), where they stay useful because daily.dev's OAuth can't redirect to localhost; production builds drop the code and POST /api/auth answers 404 - without OAuth configured, a deployment only offers the demo - README, CONTRIBUTING and .env.example updated Part of #74. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 47 minutes. View limit detailsLimit details: You’ve used the included review currently available. Review configuration: ⚙️ Run configuration
📒 Files selected for processing (6)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
2 tasks done
# Conflicts: # README.md
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of #74: the daily.dev team suggested dropping the "paste an API token" fallback so personal tokens don't pass through a hosted server.
POST /api/authare gated onimport.meta.env.DEV. In the production build the form isn't rendered andPOST /api/authcompiles down toreturn json({ error: "Not found" }, 404); the token validation code is gone from the bundle (checked in.vercel/output).pnpm dev. daily.dev rejects every loopback redirect URI, so OAuth can't complete locally. Pasting a token is the only way to try real mode on a dev server, and the e2e suite (which runs on the dev server) keeps covering it.?login=unavailablemessage now points to the demo instead of the token..env.exampledescribe the new setup.Test plan
pnpm build, then inspected the bundle: no token form markup,POST /api/auth→ 404pnpm lint,pnpm format:check,pnpm test(28 passed; the token tests still run against the dev server)🤖 Generated with Claude Code