Repository navigation
refactor(hooks): use an explicit react/purity disable instead of a Date helper - #375
Conversation
…te helper Replace the module-level currentTimestamp() helper, which only routed around the react(purity) rule, with an oxlint-disable-next-line directive and rationale at the render-phase call site. Matches the pattern used in personal-deck. No behaviour change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review. 📜 Recent review details⏰ Context from checks skipped due to timeout. (3)
🔇 Additional comments (1)
📝 SummarySummary by CodeRabbit
WalkthroughWhen the normalized app-ID list is empty after an app-ID-key change, ChangesSteam data timestamp update
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~5 minutes Change: Refactor Merge Risk: ⚪ Minimal · up to No actionable merge-blocking risk is established by the described change; it can proceed through normal checks. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. A rabbit checks the ticking clock Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Summary
#373 silenced the oxlint 1.86
react(purity)error inuseSteamAchievementsBatchby movingnew Date()into a module-levelcurrentTimestamp()helper. That only hides the call from the rule — the clock is still read during render.This replaces the helper with an explicit
// oxlint-disable-next-line react/purityplus a rationale at the call site, so the intentional exception is visible and greppable. Same pattern as the other repos.No behaviour change.
Verification
pnpm lint(oxlint + typecheck): passpnpm format:check: passpnpm test: 74 files, 745 tests passedreact(purity)athooks/use-steam-data.ts:62, so the directive is required (not dead).🤖 Generated with Claude Code