Enum member names are not lexical bindings#178
Merged
Conversation
Enum members (Some/None) do not leak into the lexical scope -- they are reached via Enum.Some / destructure, a type-system concern. The lexical-scopes pass now treats a constructor name like a record field name: neither bound nor resolved; only the payload types resolve. Fixes the earlier walk_type_member registering Some/None as binds.
|
📦 This PR will release v0.86.1 (patch) when merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a scope-resolution mistake from #177: enum member names (
Some/None) were being registered as lexical bindings. They should not be.Per the type-system design, enum members do not leak into the enclosing lexical scope — they are reached via
Enum.Some(qualified) or{Some} = Enum(destructure), which is a type-system concern, not lexical scoping. The lexical-scopes pass now treats a constructor name like a record field name: neither bound nor resolved; only the payload types resolve against the generic params.Change
walk_type_member:Some T(payload constructor) — skip the constructor name, resolve only the payload args as type references.None(nullary constructor) — neither bound nor resolved.Testing
Full suite green: 1345 lib + 42 CLI + 1 interop, 0 failed. Updated the
test_scope_types.fnkenum fixture to assert nobindforSome/None(onlybind 'T'for the generic param andref 'T'for the payload).