fix: guard runner against fn-proxy last_val#24
Merged
Conversation
The playground runner trapped with "No default value" when a fink module's last expression was a closure (e.g. a `main = fn ...` binding with nothing trailing). `formatLastVal` fell through to `String(v)`, which invoked the fn-proxy and tripped wasm. Treat fn values explicitly in `formatLastVal` (return 'fn'), and add a safe fallback for unknown values. Module-level `main(...)` invocation is kept and now runs only when `main` is actually a callable export. Also enable esbuild sourcemaps for both bundles, and bump wasm-bindgen 0.2.120 → 0.2.121 (patch).
|
This PR will release v1.16.1 |
|
🎉 This PR is included in version 1.16.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
formatLastValnow treatsfunctionexplicitly and falls back safely instead of invoking the fn-proxy viaString(v).Test plan
make build)main = fn ...binding — no trap, runner reportslast = fnand thenmain → ...