Fix extended-hours orders: market_hours must match extended_hours - #42
Merged
finlayi merged 4 commits intoJul 22, 2026
Merged
Conversation
Stock orders always sent "market_hours": "regular_hours", even when
--extended-hours was set. The Robinhood order API rejects that
combination with:
400 {"non_field_errors":["Extended hours and market hours mismatch."]}
so every extended-hours order failed. Set market_hours to
"extended_hours" when the extended-hours flag is on.
Verified against the live API: an --extended-hours limit order that
previously drew the 400 above is accepted with this change.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
finlayi
approved these changes
Jul 22, 2026
finlayi
left a comment
Owner
There was a problem hiding this comment.
Verified implementation, regression coverage, release metadata, and green Go/NPM/native CI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Stock orders always send
"market_hours": "regular_hours"in the order payload, even when--extended-hoursis set. The Robinhood order API rejects the contradictory combination:so every
--extended-hoursorder fails withBROKER_REJECTED.Repro:
Fix
Set
market_hoursto"extended_hours"whenintent.ExtendedHoursis true (payload construction inpkg/rhx/brokerage_orders.go).Verification
go test ./...passes.state: unconfirmed), and behaves normally through cancel.🤖 Generated with Claude Code