Skip to content

docs(windows): add git-bash/MSYS2 (Cygwin) incompatibility note to WINDOWS-GUIDE - #30

Closed
0xReSan wants to merge 2 commits into
finogeeks:mainfrom
0xReSan:docs/projfs-install-command
Closed

docs(windows): add git-bash/MSYS2 (Cygwin) incompatibility note to WINDOWS-GUIDE#30
0xReSan wants to merge 2 commits into
finogeeks:mainfrom
0xReSan:docs/projfs-install-command

Conversation

@0xReSan

@0xReSan 0xReSan commented Jul 31, 2026

Copy link
Copy Markdown

Adds a trade-off note to WINDOWS-GUIDE (EN + ZH) documenting that the Windows sandbox targets native binaries, and that MSYS2/Cygwin runtimes (git-bash) cannot initialize under the RestrictedToken backend (CreateFileMapping of the user-SID shared-memory object denied), which breaks Hermes tools (write_file / terminal / execute_code) routed through git-bash. References upstream issue #29. Includes the ProjFS install command note from the earlier commit on this branch.

xulis added 2 commits July 12, 2026 14:56
- Add Enable-WindowsOptionalFeature command to setup table in §1
- Add manual install code block + verify command to §5 (large trees)
- Update both English and Chinese versions
…rictedToken backend

Adds a trade-off note to WINDOWS-GUIDE (EN + ZH): the sandbox targets native
Windows binaries; MSYS2/Cygwin runtimes (git-bash) cannot initialize under
RestrictedToken (CreateFileMapping of user-SID shared-memory object denied),
so Hermes tools routed through git-bash (write_file/terminal/execute_code)
fail inside the sandbox. References upstream issue finogeeks#29.
@github-actions

Copy link
Copy Markdown
Contributor

Thanks for the contribution!

This repository is a release mirror — end-user docs are authored upstream in docs/public-finsafe/ and synced to finogeeks/finsafe on each public release. We do not merge PRs here as the long-term fix; maintainers cherry-port substantive edits upstream and close this PR with a link to the upstream change.

Your PR touches documentation / examples only, so it may be labeled triage:docs-only. A maintainer will review and port it when convenient; the update will appear on public main after the next release sync (or a manual docs push).

  • CONTRIBUTING.md
  • For bugs in finsafe behavior, please also consider opening an issue with the bug label so release automation can link a fix version.

@github-actions github-actions Bot added the triage:docs-only Public docs / install script only (mirror PR) label Jul 31, 2026
@Geeksfino

Copy link
Copy Markdown
Contributor

Thanks — cherry-ported upstream into Geeksfino/finsafe docs/public-finsafe/ and published to this mirror via docs-only sync (no new CLI release).

Closing this PR per CONTRIBUTING (mirror PRs are not merged directly). The WINDOWS-GUIDE note is now on main here.

@Geeksfino

Copy link
Copy Markdown
Contributor

Closed: docs live on main via upstream port (see previous comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

triage:docs-only Public docs / install script only (mirror PR)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants