feat(calm-hub): enable opentelemetry and json logging support - #3054
Vanshikaa1510 wants to merge 3 commits into
Conversation
|
|
rocketstack-matt
left a comment
There was a problem hiding this comment.
This adds tracing + JSON logging but doesn't address metrics, one of the three pillars #2945 asks for (sync health, API latency percentiles, cache hit rates, session operations). As it stands this PR shouldn't close #2945 — either metrics needs to be split into its own issue/PR, or added here. @byrash, can you confirm which approach you'd prefer?
Also requesting: documentation for the two new env vars (CALM_OTEL_ENABLED, OTEL_EXPORTER_OTLP_ENDPOINT) in calm-hub/README.md or AGENTS.md — these are new operator-facing config and should be documented before merge.
| quarkus.otel.exporter.otlp.traces.endpoint=${OTEL_EXPORTER_OTLP_ENDPOINT:http://localhost:4317} | ||
|
|
||
| # JSON Logging format | ||
| quarkus.log.console.json=${CALM_OTEL_ENABLED:false} |
There was a problem hiding this comment.
JSON console logging shouldn't be gated behind CALM_OTEL_ENABLED — an operator should be able to get structured JSON logs for log aggregation without also enabling OTLP trace export, and vice versa. Give it its own flag.
| quarkus.log.console.json=${CALM_OTEL_ENABLED:false} | |
| quarkus.log.console.json=${CALM_JSON_LOGGING_ENABLED:false} |
| quarkus.log.category."org.mongodb.driver".level=OFF No newline at end of file | ||
| quarkus.log.category."org.mongodb.driver".level=OFF | ||
|
|
||
| # OpenTelemetry configuration |
There was a problem hiding this comment.
Every other toggle in this file documents its default and how to override it in a comment (see calm.mcp.enabled, calm.readonly, the audit-logging block above). This block just says "OpenTelemetry configuration" — name CALM_OTEL_ENABLED / OTEL_EXPORTER_OTLP_ENDPOINT (and CALM_JSON_LOGGING_ENABLED per the fix above) explicitly so it matches the existing convention.
|
Hi @rocketstack-matt, I have addressed all the requested changes (logging flag separation, metrics, and documentation) and pushed the latest commits. Could you please re-review this PR when you get a chance? Thanks! |
|
Thanks for following up — but I'm not seeing those changes in the diff. The branch head is still |
|
Hi @rocketstack-matt , I have resolved the merge conflicts, separated CALM_JSON_LOGGING_ENABLED from CALM_OTEL_ENABLED in application.properties, and updated calm-hub/README.md. Regarding the metrics requirement from #2945, I will address metrics in a separate follow-up PR. Please re-review these changes. |
Description
Enabled OpenTelemetry tracing and JSON logging format for the
calm-hubmodule.Closes #2945
Type of Change
Affected Components
cli/)calm/)calm-ai/)calm-hub/)calm-hub-ui/)calm-server/)calm-widgets/)docs/)shared/)calm-plugins/vscode/)Testing
Checklist