Fix junit-platform version pinned by xtext-dev-bom shadowing junit.version - #423
Merged
hugohills-regnosys merged 1 commit intoSep 15, 2026
Conversation
xtext-dev-bom (imported above junit-bom in dependencyManagement) pins
junit-platform-commons/junit-platform-engine to its own
junit-platform-version (1.10.2), and since it's imported first, that
pin wins over junit-bom's. Bumping junit.version to 6.1.3 left
junit-jupiter-engine:6.1.3 running against junit-platform-engine:1.10.2,
which predates the closeAutoCloseables() API jupiter-engine 6.1.3 calls:
java.lang.NoSuchMethodError: 'org.junit.platform.engine.support.store.NamespacedHierarchicalStore$CloseAction org.junit.platform.engine.support.store.NamespacedHierarchicalStore$CloseAction.closeAutoCloseables()'
Fix: add explicit dependencyManagement entries for junit-platform-commons
and junit-platform-engine at ${junit.version}, mirroring the existing
junit-jupiter-api/junit-jupiter-engine overrides right above them.
Verified: `mvn dependency:tree` now resolves junit-platform-* to 6.1.3,
and `mvn test` passes all 94 tests (previously failed with the error
above).
hugohills-regnosys
merged commit Sep 15, 2026
5474fd5
into
finos:dependabot/maven/junit.version-6.1.3
6 checks passed
hugohills-regnosys
added a commit
that referenced
this pull request
Sep 15, 2026
* Bump junit.version from 5.9.1 to 6.1.3 Bumps `junit.version` from 5.9.1 to 6.1.3. Updates `org.junit:junit-bom` from 5.9.1 to 6.1.3 - [Release notes](https://github.com/junit-team/junit-framework/releases) - [Commits](junit-team/junit-framework@r5.9.1...r6.1.3) Updates `org.junit.jupiter:junit-jupiter-api` from 5.9.1 to 6.1.3 - [Release notes](https://github.com/junit-team/junit-framework/releases) - [Commits](junit-team/junit-framework@r5.9.1...r6.1.3) Updates `org.junit.jupiter:junit-jupiter-engine` from 5.9.1 to 6.1.3 - [Release notes](https://github.com/junit-team/junit-framework/releases) - [Commits](junit-team/junit-framework@r5.9.1...r6.1.3) --- updated-dependencies: - dependency-name: org.junit.jupiter:junit-jupiter-api dependency-version: 6.1.3 dependency-type: direct:production update-type: version-update:semver-major - dependency-name: org.junit.jupiter:junit-jupiter-engine dependency-version: 6.1.3 dependency-type: direct:production update-type: version-update:semver-major - dependency-name: org.junit:junit-bom dependency-version: 6.1.3 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * Override xtext-dev-bom's junit-platform pin to match junit.version (#423) xtext-dev-bom (imported above junit-bom in dependencyManagement) pins junit-platform-commons/junit-platform-engine to its own junit-platform-version (1.10.2), and since it's imported first, that pin wins over junit-bom's. Bumping junit.version to 6.1.3 left junit-jupiter-engine:6.1.3 running against junit-platform-engine:1.10.2, which predates the closeAutoCloseables() API jupiter-engine 6.1.3 calls: java.lang.NoSuchMethodError: 'org.junit.platform.engine.support.store.NamespacedHierarchicalStore$CloseAction org.junit.platform.engine.support.store.NamespacedHierarchicalStore$CloseAction.closeAutoCloseables()' Fix: add explicit dependencyManagement entries for junit-platform-commons and junit-platform-engine at ${junit.version}, mirroring the existing junit-jupiter-api/junit-jupiter-engine overrides right above them. Verified: `mvn dependency:tree` now resolves junit-platform-* to 6.1.3, and `mvn test` passes all 94 tests (previously failed with the error above). --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Hugo Hills <39260692+hugohills-regnosys@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
junit.version5.9.1 → 6.1.3) fails all tests with:xtext-dev-bom(imported independencyManagementbeforejunit-bom) pinsjunit-platform-commons/junit-platform-engineto its own, olderjunit-platform-version(1.10.2) — confirmed by fetchingxtext-dev-bom-2.38.0.pomfrom Maven Central. Since it's imported first, that pin wins overjunit-bom's6.1.3.junit-jupiter-engine:6.1.3then runs againstjunit-platform-engine:1.10.2, which predates thecloseAutoCloseables()API jupiter-engine 6.1.3 calls.dependencyManagemententries forjunit-platform-commons/junit-platform-enginepinned to${junit.version}, mirroring the existingjunit-jupiter-api/junit-jupiter-engineoverrides right above them (which exist for the same reason).This targets #411's own branch (
dependabot/maven/junit.version-6.1.3), notmain— same reasoning as rune-common#738 and rune-testing#413: the fix only makes sense paired with this exact bump.Test plan
mvn dependency:tree—junit-platform-commons/junit-platform-enginenow resolve to6.1.3(previously1.10.2).mvn test— all 94 tests pass (previously failed with the error above).