-
Notifications
You must be signed in to change notification settings - Fork 70
feat(firestore): add Settings.headers to attach custom request headers #307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
demolaf
wants to merge
10
commits into
main
Choose a base branch
from
firestore/settings-headers
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
6fd08a3
fix(ci): use allow-listed codecov-action@v4 ref instead of a SHA pin
demolaf 005b4a7
test(ci): try pinning codecov-action to the actual v4 release SHA
demolaf 01a5a85
Revert "test(ci): try pinning codecov-action to the actual v4 release…
demolaf 63e980e
feat(firestore): add Settings.headers to attach custom request headers
demolaf 14f9e46
fix(firestore): append caller headers instead of overwriting existing…
demolaf d210b9d
test(firestore): add unit tests for FirestoreRequestClient header mer…
demolaf 2ac3e1a
fix(firestore): address review feedback on Settings.headers
demolaf fb5a004
Merge remote-tracking branch 'origin/fix/ci-codecov-action-allowlist'…
demolaf e430080
fix(admin): attach usage-tracking headers to Firestore requests (#308)
demolaf c3d0d42
Merge branch 'main' into firestore/settings-headers
demolaf File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
127 changes: 127 additions & 0 deletions
127
packages/google_cloud_firestore/test/firestore_request_client_test.dart
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,127 @@ | ||
| // Copyright 2026 Google LLC | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| import 'package:google_cloud_firestore/src/firestore_http_client.dart'; | ||
| import 'package:googleapis_auth/auth_io.dart' as googleapis_auth; | ||
| import 'package:http/http.dart'; | ||
| import 'package:http/testing.dart'; | ||
| import 'package:test/test.dart'; | ||
|
|
||
| /// Wraps a plain [Client] (such as [MockClient]) so it satisfies the | ||
| /// [googleapis_auth.AuthClient] interface [FirestoreRequestClient] requires. | ||
| class _FakeAuthClient extends BaseClient implements googleapis_auth.AuthClient { | ||
| _FakeAuthClient(this._inner); | ||
|
|
||
| final Client _inner; | ||
| bool closed = false; | ||
|
|
||
| @override | ||
| googleapis_auth.AccessCredentials get credentials => | ||
| throw UnimplementedError(); | ||
|
|
||
| @override | ||
| Future<StreamedResponse> send(BaseRequest request) => _inner.send(request); | ||
|
|
||
| @override | ||
| void close() { | ||
| closed = true; | ||
| _inner.close(); | ||
| } | ||
| } | ||
|
|
||
| void main() { | ||
| group('FirestoreRequestClient', () { | ||
| test('sets a header that has no existing value', () async { | ||
| late Request captured; | ||
| final mock = MockClient((request) async { | ||
| captured = request; | ||
| return Response('{}', 200); | ||
| }); | ||
|
|
||
| final client = FirestoreRequestClient(_FakeAuthClient(mock), { | ||
| 'X-Firebase-Client': 'fire-admin-dart/1.0.0', | ||
| }); | ||
|
|
||
| await client.get(Uri.parse('https://firestore.googleapis.com/')); | ||
|
|
||
| expect(captured.headers['X-Firebase-Client'], 'fire-admin-dart/1.0.0'); | ||
| }); | ||
|
|
||
| test( | ||
| 'appends to (rather than overwrites) an existing header value', | ||
| () async { | ||
| late Request captured; | ||
| final mock = MockClient((request) async { | ||
| captured = request; | ||
| return Response('{}', 200); | ||
| }); | ||
|
|
||
| final client = FirestoreRequestClient(_FakeAuthClient(mock), { | ||
| 'X-Goog-Api-Client': 'fire-admin/1.0.0', | ||
| }); | ||
|
|
||
| final request = Request( | ||
| 'GET', | ||
| Uri.parse('https://firestore.googleapis.com/'), | ||
| ); | ||
| // Simulates the value package:google_cloud_rpc already sets. | ||
| request.headers['X-Goog-Api-Client'] = | ||
| 'gl-dart/3.9 gax/1.0 rest/1.0 gapic/1.0'; | ||
|
|
||
| await client.send(request); | ||
|
|
||
| expect( | ||
| captured.headers['X-Goog-Api-Client'], | ||
| 'gl-dart/3.9 gax/1.0 rest/1.0 gapic/1.0 fire-admin/1.0.0', | ||
| ); | ||
| }, | ||
| ); | ||
|
|
||
| test('applies multiple headers independently', () async { | ||
| late Request captured; | ||
| final mock = MockClient((request) async { | ||
| captured = request; | ||
| return Response('{}', 200); | ||
| }); | ||
|
|
||
| final client = FirestoreRequestClient(_FakeAuthClient(mock), { | ||
| 'X-Firebase-Client': 'fire-admin-dart/1.0.0', | ||
| 'X-Goog-Api-Client': 'fire-admin/1.0.0', | ||
| }); | ||
|
|
||
| await client.get(Uri.parse('https://firestore.googleapis.com/')); | ||
|
|
||
| expect(captured.headers['X-Firebase-Client'], 'fire-admin-dart/1.0.0'); | ||
| expect(captured.headers['X-Goog-Api-Client'], 'fire-admin/1.0.0'); | ||
| }); | ||
|
|
||
| test('delegates close() to the inner client', () { | ||
| final mock = MockClient((request) async => Response('{}', 200)); | ||
| final inner = _FakeAuthClient(mock); | ||
| final client = FirestoreRequestClient(inner, const {}); | ||
|
|
||
| client.close(); | ||
|
|
||
| expect(inner.closed, isTrue); | ||
| }); | ||
|
|
||
| test('delegates credentials to the inner client', () { | ||
| final mock = MockClient((request) async => Response('{}', 200)); | ||
| final inner = _FakeAuthClient(mock); | ||
| final client = FirestoreRequestClient(inner, const {}); | ||
|
|
||
| expect(() => client.credentials, throwsUnimplementedError); | ||
| }); | ||
| }); | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.