Repository navigation
developer: use server passage budget from search#843 - #194
Merged
Merged
Conversation
Member
Author
|
@cubic-dev-ai review |
Contributor
@PhantomInTheWire I have started the AI code review. It will take a few minutes to complete. |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 6 files
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
Member
Author
|
@cubic-dev-ai review |
Contributor
@PhantomInTheWire I have started the AI code review. It will take a few minutes to complete. |
Member
Author
|
@cubic-dev-ai review |
Contributor
@PhantomInTheWire I have started the AI code review. It will take a few minutes to complete. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
passage_budgeton developer-search requestspassage_budget_appliedis presentDecision: server-side policy, no client knob.
The fallback retains the TODO to remove it after firecrawl/search#843 is enabled everywhere.
Verification
pnpm run format:checkpnpm run type-checkpnpm run buildpnpm run test(423 passed)