Repository navigation
fix(cli): restore list category fallback for unknown providers - #249
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
firecrawl list shoppingprobesshoppingas a provider before trying it as a category. The API now rejects unknown providers, so that error previously stopped the category fallback.Allow the existing fallback for the unknown-provider code or the API's specific unknown/unavailable-provider message. Preserve provider-first precedence and continue surfacing rate-limit, authentication, transport and other errors. No API or version changes.
Validation: TypeScript build, formatting, and compiled CLI regression against a local API fixture. The regression checks the reported shopping failure and that rate-limit errors do not trigger fallback.
Summary by cubic
Restores the category fallback in
firecrawl listso commands likefirecrawl list shoppingstill work when the API rejects unknown providers.Previously, the API's unknown-provider error stopped the existing category fallback, so browsing a category by name failed. Now the fallback proceeds when the API reports an unknown or unavailable provider, while rate-limit, authentication, transport, and other errors still surface as failures. Provider-first precedence is unchanged, and there are no API or version changes.
Written for commit cdcfc2c. Summary will update on new commits.