Repository navigation
fix(cli): send documented default search limit - #250
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
firecrawl searchdocuments a default of 5 results, but when--limitis omitted the CLI omitted the field from the/v2/searchbody. The API then applied its default of 10, so authenticated and keyless CLI requests returned more results than documented.Change
Apply the CLI's documented default (
limit: 5) in the shared search payload builder. Explicit--limitvalues continue to pass through unchanged, and both authenticated and keyless paths use the same body.Validation
pnpm buildpnpm exec vitest run src/__tests__/commands/search.test.ts(42 passed)pnpm exec prettier --check src/commands/search.ts src/__tests__/commands/search.test.tsgit diff --checkSummary by cubic
Fixes
firecrawl searchto send the documented default of 5 results when--limitis omitted, instead of letting the API default to 10. Explicit--limitvalues still pass through unchanged for both authenticated and keyless requests.Written for commit 945d0fa. Summary will update on new commits.