Repository navigation
Support provider/capability shorthand in firecrawl scrape - #254
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 8 files
Shadow auto-approve: would not auto-approve because issues were found.
Fix all with cubic | Re-trigger cubic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Allow
firecrawl scrape benzinga/news/search --options '{"pageSize":10}'alongside the existing--alexandria benzinga/news/searchsyntax. Both forms use the same Alexandria execution path and make no extra catalog lookup.URL-shaped inputs stay on website scraping, including explicit HTTP(S) URLs, domains, localhost and IP addresses. Bare names such as
firecrawl scrape amazonfail before authentication with a suggested website URL,firecrawl list, and tool syntax. Suggestions are never executed. Unknown provider/capability paths retain the server error and nonzero exit status; they never fall back to a URL scrape.Preserve multi-URL scraping and positional formats. Reject mixed URL/tool requests and mixed positional/explicit tool addressing instead of silently ignoring inputs. Update scrape help and README with both forms.
Validation
pnpm buildpasses.Summary by cubic
Adds provider/capability shorthand to
firecrawl scrape, alongside--alexandria, with no extra catalog lookup. Both forms use the same Alexandria execution path.--urlforms, with a suggested URL and pointer tofirecrawl list; suggestions are never executed.--alexandriatool addresses are rejected.Written for commit 0f51406. Summary will update on new commits.