Skip to content

Add missing_capability issue to alexandria feedback - #272

Merged
nickscamara merged 2 commits into
mainfrom
nsc/alexandria-feedback-missing-capability
Sep 22, 2026
Merged

nickscamara merged 2 commits into
mainfrom
nsc/alexandria-feedback-missing-capability

Conversation

@nickscamara

@nickscamara nickscamara commented Sep 22, 2026 •

Copy link
Copy Markdown
Member

What changed

  • firecrawl alexandria feedback: --capability-feedback now accepts the new missing_capability issue code (the provider exists but lacks this capability). It is accepted with or without requestedFunctionality. new_capability_request still requires requestedFunctionality; unknown issue codes are still rejected before anything is posted.
  • Help text for --capability-feedback lists the new code with its meaning.
  • Docs: README firecrawl alexandria feedback section now enumerates the capability issue codes; skills/firecrawl-agent/SKILL.md gets a one-line hint on when to use missing_capability vs new_capability_request.
  • Tests: unit cases for parseAlexandriaFeedbackArray (accepted with/without requestedFunctionality, new_capability_request still rejected without it, unknown code still rejected) and an end-to-end case asserting the CLI posts missing_capability to POST /v2/feedback unchanged.

Context

Pairs with the API change that moves Alexandria feedback into dedicated tables server-side and extends capabilityFeedback[].issue with missing_capability:

No client-visible change to the request shape other than the new issue value. No version bump or changelog entry (the repo has none).

Test plan

  • pnpm install --frozen-lockfile, pnpm build (tsc): pass
  • pnpm format / pnpm format:check: clean
  • pnpm test (vitest): 34 files, 592 tests pass
  • Focused: pnpm vitest run src/__tests__/commands/feedback.test.ts src/__tests__/alexandria-beta.test.ts -t "missing_capability|malformed": pass

Summary by cubic

Adds missing_capability as a valid issue code for firecrawl alexandria feedback --capability-feedback, so users can report when a provider exists but lacks the needed capability. It's accepted with or without requestedFunctionality; new_capability_request still requires it, and unknown codes are still rejected before anything is posted.

Docs and tests

  • Updates the --capability-feedback help text, README, and SKILL.md to list the new code.
  • Adds unit and end-to-end tests covering acceptance, the requestedFunctionality requirement, and rejection of unknown codes.
  • Bumps the package version to 1.24.1.
  • Works with a companion API change that extends the capability feedback issue set.

Written for commit 2536c85. Summary will update on new commits.

Review in cubic

Co-authored-by: Cursor <cursoragent@cursor.com>

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 5 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Shadow auto-approve: would require human review. Adds missing_capability as a valid issue code for --capability-feedback, extending the request contract and relying on companion API/DB changes; needs human sign-off on API/data semantics and deployment coordination.

Re-trigger cubic

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0 issues found across 1 file (changes from recent commits).

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Shadow auto-approve: would require human review. Adds missing_capability as a new accepted capability-feedback issue code, extending the request contract and depending on companion API/database changes; needs human sign-off on contract semantics and deployment coordination.

Re-trigger cubic

@nickscamara
nickscamara merged commit a3c9ee9 into main Sep 22, 2026
8 checks passed
@nickscamara
nickscamara deleted the nsc/alexandria-feedback-missing-capability branch September 22, 2026 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant