Fix init package manager detection and incomplete setup reporting - #276
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 4 files
Shadow auto-approve: would not auto-approve because issues were found.
Tip: instead of fixing issues one by one fix them all with cubic
Re-trigger cubic
Contributor
There was a problem hiding this comment.
0 issues found across 4 files (changes from recent commits).
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Shadow auto-approve: would auto-approve. Fixes init's package manager detection and incomplete setup reporting: global installs now use the detected manager, failures preserve completed setup and exit 1, and next-step commands reflect the manager. Adds detection utility and tests; bounded to the init command and clearly beneficial.
Re-trigger cubic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
init --allruns through bunx or pnpm, global installation now uses the detected package manager instead of always invoking npm. Setup checks the selected manager version before installing and rejects obsolete npm with a diagnostic rather than suggesting sudo.Failed global installation preserves completed authentication and skill setup, reports incomplete setup, and exits with code 1. Retry commands, global-bin guidance, and next-step commands use the selected package manager. Skipped or failed skill installs no longer produce an unconditional success summary.
Validation: build and formatting passed; all 609 tests passed with an isolated home directory. Six built-CLI subprocess checks with stub npm/pnpm/Bun executables verified install selection, obsolete npm rejection, and failure exit codes. These six checks did not perform real installs; subsequent real install validation is detailed below. No package was published.
Real package-manager validation (packed branch build, isolated HOME/global directories, authentication and skills skipped):
The real runs used the packed modified CLI to execute init; global installs fetched the package manager’s registry-selected release. No package was published.