Fixes - #277
Merged
Merged
Fixes#277
Conversation
Member
Author
|
@cubic review |
Contributor
@nickscamara I have started the AI code review. It will take a few minutes to complete. |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 3 files
Shadow auto-approve: would not auto-approve because issues were found.
Fix all with cubic | Re-trigger cubic
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 3 files
Shadow auto-approve: would not auto-approve because issues were found.
Fix all with cubic | Re-trigger cubic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
The
--alexandriaflag now accepts the HTTP contract's JSON object form alongside the existingprovider/capabilityaddress, andfind-toolslist selectors accept comma-separated strings. Validation is stricter: malformed addresses and conflicting options are rejected locally instead of reaching the API.normalizeFindToolsOptionssoproviders,categories,groups,capabilities, andexpandaccept comma-separated strings;urlsis never split since commas are legal inside URLs.--alexandriaparses bare addresses (trimming whitespace around the slash) and JSON objects; options inside the object and via--optionsare mutually exclusive, and empty address parts are rejected.Written for commit cab9efd. Summary will update on new commits.