Conversation
`--full-page-screenshot` was added to the request but not to the output formats, so `firecrawl scrape <url> --full-page-screenshot` printed only the markdown and dropped the screenshot URL. Combined with `--format screenshot` it sent two screenshot formats, which the API rejects with "You may only specify one screenshot format". The full-page screenshot now replaces a plain `screenshot` format and counts as a screenshot when choosing the output shape, the same way `--screenshot` already does. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 2 files
Shadow auto-approve: would not auto-approve because issues were found.
Fix all with cubic | Re-trigger cubic
Also cover --screenshot together with --full-page-screenshot. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
0 issues found across 2 files (changes from recent commits).
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Shadow auto-approve: would auto-approve. Fixes --full-page-screenshot so the screenshot output format replaces plain screenshot and the CLI prints the returned screenshot URL; the corrected behavior is pinned by new tests and is a focused, clearly beneficial bug fix.
Re-trigger cubic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's wrong
--full-page-screenshotgoes into the request but not into the output formats. The flag also doesn't replace a plainscreenshotformat. This causes two failures:firecrawl scrape https://example.com --full-page-screenshotprints only the markdown. The API returns a screenshot URL, but the CLI never shows it, so the user pays for a screenshot they never see.--screenshotworks becausehandleScrapeCommandaddsscreenshotto the output formats for that flag only.firecrawl scrape https://example.com -f screenshot --full-page-screenshotsendsformats: ["screenshot", {"type":"screenshot","fullPage":true}]. The v2 scrape schema has the refineYou may only specify one screenshot format, so the command fails with that error.Reproduced against a local fake
/v2/scrapethat applies the same one-screenshot rule:Fix
executeScrape: whenfullPageScreenshotis set, drop a plainscreenshotentry before adding{ type: 'screenshot', fullPage: true }.handleScrapeCommand: countfullPageScreenshotas a screenshot when choosing the output shape, the same way--screenshotis counted.handleAllScrapeCommandalready does this.After the fix the two commands above print
{"markdown":"# Hello","screenshot":"https://…"}and the formattedScreenshot: https://…block.Tests
Two new cases in
src/__tests__/commands/scrape.test.ts:--format markdown,screenshotplusfullPageScreenshotsends exactly one screenshot format.handleScrapeCommandwithfullPageScreenshotprints the screenshot URL next to the markdown.Both fail on
mainand pass with the fix.pnpm run format:check,pnpm run type-check,pnpm run buildandpnpm test(642 tests) pass.This PR was prepared with an AI coding agent (Claude). I reproduced the bug and checked the fix and tests before opening it.
Summary by cubic
Fixes
--full-page-screenshotso the screenshot URL is included in CLI output instead of being silently dropped. The flag now replaces any plainscreenshotoutput format, preventing the "You may only specify one screenshot format" API error.Written for commit 0140582. Summary will update on new commits.