Repository navigation
feat: add --objective to alexandria feedback - #292
Merged
Merged
Conversation
Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
There was a problem hiding this comment.
No issues found across 7 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Shadow auto-approve: would require human review. Adds a required --objective flag to the Alexandria feedback CLI and sends it in the POST /v2/feedback payload; the decisive factor is the public CLI/API contract change and the dependency on backend deploy firecrawl/firecrawl#4877 for compatibility.
Re-trigger cubic
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
firecrawl alexandria feedbacknow requires--objective <text>: the underlying goal behind the session, meaning what the agent or its user was ultimately trying to accomplish. This is broader than--requested-functionality, which only covers the one website.objectiveinPOST /v2/feedback.firecrawl-alexandriaandfirecrawl-agentskills and the README explain the field and include it in their examples. After merge, the skills sync tofirecrawl/skillsautomatically.Depends on
Tests
vitest run: 657/657 pass. The tests cover the payload with a trimmed objective and rejection of a missing or blank--objectivebefore any request is sent.Made with Cursor
Summary by cubic
Adds a required
--objectiveflag tofirecrawl alexandria feedbackso sessions capture the underlying goal of the task, which is broader than--requested-functionality. The value is trimmed, must be 1–2000 characters, and is sent as the top-levelobjectiveinPOST /v2/feedback. The package version is bumped to1.25.1.--objectiveis rejected before any request is sent.firecrawl-alexandriaandfirecrawl-agentskills and the README document the field and include it in examples.firecrawl/firecrawl#4877to be deployed before release; the API rejects unknown keys until then.Written for commit 254cd54. Summary will update on new commits.