Skip to content

Update browser.ts #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
developersdigest merged 2 commits into from
Feb 17, 2026
Merged

Update browser.ts #33

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
68ec055
Update browser.ts
developersdigest Feb 17, 2026
c1e0f00
update package
developersdigest Feb 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "firecrawl-cli",
"version": "1.4.0",
"version": "1.4.1",
"description": "Command-line interface for Firecrawl. Scrape, crawl, and extract data from any website directly from your terminal.",
"main": "dist/index.js",
"bin": {
Expand Down
14 changes: 2 additions & 12 deletions src/commands/browser.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,24 +113,14 @@ export async function handleBrowserLaunch(

/**
* Execute a bash command locally with CDP_URL and SESSION_ID env vars.
* Auto-injects --cdp for agent-browser commands.
* agent-browser reads CDP_URL from the environment automatically.
*/
export function executeBashLocally(
command: string,
session: { id: string; cdpUrl: string }
): Promise<{ stdout: string; stderr: string; exitCode: number }> {
return new Promise((resolve) => {
// Auto-inject --cdp for agent-browser commands
let finalCommand = command;
if (command.startsWith('agent-browser') && !command.includes('--cdp')) {
const parts = command.split(' ');
// Insert --cdp after "agent-browser <subcommand>"
const insertIdx = Math.min(2, parts.length);
parts.splice(insertIdx, 0, '--cdp', `'${session.cdpUrl}'`);
finalCommand = parts.join(' ');
}

const child = spawn('sh', ['-c', finalCommand], {
const child = spawn('sh', ['-c', command], {
env: {
...process.env,
CDP_URL: session.cdpUrl,
Expand Down