Repository navigation
Point agents at Alexandria feedback from instructions, descriptions and results - #428
Merged
Merged
Conversation
…nd results Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
rakshith48
added a commit
that referenced
this pull request
Sep 22, 2026
Resolves conflicts in the profile instructions, the scrape tool schema, the feedback schema and the CHANGELOG, and threads the new Alexandria surface: firecrawl_find_tools declares threadId (its schema is strict), the Alexandria-mode refinement on firecrawl_scrape allows threadId alongside alexandria, and result stamping keeps compact JSON compact now that main emits compact results. Two Alexandria tests that deep-compare payloads split off the thread ID first. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Agents using Alexandria purely through MCP were never told to send feedback: the
firecrawl_find_toolsandfirecrawl_scrapedescriptions and the server instructions did not mention it, andfirecrawl_feedbackonly described the Alexandria mode inside its own schema. Search, by contrast, surfaces its feedback loop in the tool description and through the responseid.These commits were pushed to
alexandria-mcpafter #405 had already been squash-merged, so they are re-applied here on top ofmain.Summary
The pointer now appears in three places:
FULL_PROFILE_INSTRUCTIONS) and the Alexandria block of the fullfirecrawl_searchdescription: after an Alexandria task, whether a capability ran or discovery found nothing for the website, callfirecrawl_feedbackonce per website withendpoint: "alexandria".firecrawl_scrape(Alexandria mode) andfirecrawl_find_toolsdescriptions: one sentence each pointing atfirecrawl_feedbackand thefeedbackToolresult field.feedbackToolobject on every Alexandria execution result (inline and retained) and everyfirecrawl_find_toolsresult, carrying the tool name and an argument skeleton.The hint is omitted for Firecrawl-internal calls (
bash,terms/*) and wheneverfirecrawl_feedbackis not registered (FIRECRAWL_NO_ENDPOINT_FEEDBACKor keyless startup), so it never points at a tool that does not exist. The search-only marketplace profile is unchanged.Test plan
tests/mcp-alexandria-feedback-hints.test.mjs: instructions and descriptions, hints on execution and discovery results, no hint onbash, hint on retained results, no hint when disabled by environment.npm test: 114/114 (includes the agent metadata policy check on the new wording).npm run lint: only the 3 preexisting errors insrc/alexandria.ts.Made with Cursor
Summary by cubic
Adds feedback pointers so agents using Alexandria through MCP learn to report how the catalogue served the website.
firecrawl_scrape,firecrawl_find_tools, andfirecrawl_searchdescriptions.feedbackToolobject with the tool name and an argument skeleton to every Alexandria execution and discovery result, including retained results.bashand whenfirecrawl_feedbackisn't registered (FIRECRAWL_NO_ENDPOINT_FEEDBACKor keyless startup).Written for commit 48d5e0a. Summary will update on new commits.