Repository navigation
Scope keyless-unavailable tool pointers to authenticated sessions (stacked on #436) - #437
Merged
Merged
Conversation
… sessions Keyless sessions (hosted without auth, stdio without a key) list only firecrawl_search, firecrawl_scrape and firecrawl_parse, and FastMCP serves one description per tool. The search and scrape descriptions told them to call firecrawl_feedback, read contracts with firecrawl_find_tools, use Alexandria mode, and reach for firecrawl_map / firecrawl_crawl. PR 436 moved the feedback and Alexandria-mode sentences inside Claude Code's 2,048-character window, so keyless Claude Code agents would now see them. Each such sentence now says it applies on an authenticated session, and search adds 'Keyless sessions return web results only.' The keyless smoke test fails if any sentence in a keyless-listed description names an unlisted tool or Alexandria mode without saying so. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 2 files
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
…it returns web only Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
No issues found across 2 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Requires human review: This PR changes tool descriptions to scope unlisted tool references to authenticated sessions and strengthens a smoke test. It alters user-facing copy for keyless sessions and relies on prior unmerged changes, so human review is warranted.
Re-trigger cubic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #436.
Problem
Keyless sessions (hosted
/v2/mcpwithout auth, and stdio without a key) list onlyfirecrawl_search,firecrawl_scrapeandfirecrawl_parse. FastMCP serves one static description per tool, so keyless agents read the same search and scrape copy as authenticated ones, which tells them to:firecrawl_feedbackafter an Alexandria task (search and scrape),firecrawl_find_tools(search),firecrawl_map/firecrawl_crawl(scrape).None of those tools is listed for them. On
mainthe feedback sentences start at characters 4,589 (search) and 3,306 (scrape), past Claude Code's 2,048-character cut, so only Codex saw them. #436 moves them to 1,146 and 1,399, so keyless Claude Code agents would start seeing them too.Fix
firecrawl_find_tools; after an Alexandria task, call firecrawl_feedback …" plus "Keyless sessions return web results only."feedbackToolpointer …", and "on an authenticated session,firecrawl_maplists a site's URLs andfirecrawl_crawlcollects a set of pages."Per-session descriptions would need a FastMCP change (the
tools/listhandler returnstool.descriptionas registered), so this scopes the wording instead.Test
The keyless smoke test now fails if any sentence in a keyless-listed description names an unlisted
firecrawl_*tool (research tools excepted) or Alexandria mode without saying it applies to authenticated sessions. It caught the map/crawl pointer, which predates #436. Suite 120/120. Descriptions stay under the cap: search 1,872, scrape 1,545.🤖 Generated with Claude Code
Summary by cubic
Scopes tool descriptions for keyless sessions so unlisted tool references and Alexandria mode pointers only appear in authenticated-session copy.
firecrawl_find_tools,firecrawl_feedback,firecrawl_map,firecrawl_crawl, and Alexandria mode as authenticated-session features, and search notes keyless sessions get no Alexandria matches indata.tools.Written for commit 5b6839d. Summary will update on new commits.