Repository navigation
Ignore URL-mode discovery options on Alexandria scrape calls instead of rejecting them - #440
Merged
Merged
Conversation
…of rejecting them firecrawl_scrape in Alexandria mode accepted only alexandria, requestId and timeout, and failed validation with 'alexandria cannot be combined with url or other scrape options' for anything else. Codex carries toolDetail over from firecrawl_search, where it selects contract detail, and sent it on 18 of 315 Alexandria executions across the AX EXP-058 runs (8/120 on prod before PR 431, 6/180 on PR 431, 4/15 on the hosted smoke after deploy), each a wasted call before a retry without it. toolDetail and domainTools are URL-mode discovery options the Alexandria path never reads, so accept and ignore them there; both descriptions now say so. Version 3.25.5 so npm picks up this and PR 431. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
No issues found across 3 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Auto-approved: Fixes Alexandria scrape validation rejecting agent-carried URL-mode options; unknown options are now ignored instead of failing with a wasteful retry. Test pins the corrected behavior and confirms options aren't forwarded.
Re-trigger cubic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
firecrawl_scrapein Alexandria mode accepts onlyalexandria,requestIdandtimeout; any other key fails validation:Codex hits this with
toolDetail. Onfirecrawl_search,toolDetail: "full"asks for full contracts, so Codex passes the same parameter when it executes the provider it found. On scrape,toolDetailis a URL-mode domain-discovery option whose description did not say so. Across the AX EXP-058 runs (firecrawl/agent-experience):toolDetailEvery one was followed by a retry without
toolDetailthat succeeded, so each cost one wasted call and round trip. Claude did not do this.Fix
toolDetailanddomainTools. The execute path never read them in that mode (it forwards onlyalexandria,requestIdandtimeout), so they are ignored rather than rejected. Real scrape options (formats,url, …) are still rejected withalexandria.Test
New case in
tests/mcp-alexandria-scrape.test.mjs: an Alexandria call withtoolDetail: "full"anddomainTools: truesucceeds and the/v2/scrapebody carries onlyalexandriaandorigin. The existing case that rejectsformatsalongsidealexandriastill passes. Suite 122/122.🤖 Generated with Claude Code
Summary by cubic
Stops
firecrawl_scrapefrom rejectingtoolDetailanddomainToolson Alexandria calls; it now accepts and ignores them. Agents were carryingtoolDetailover fromfirecrawl_searchon 18 of 315 executions, each failing validation and wasting a call before a retry without it.Real scrape options (
url,formats, …) are still rejected withalexandria. Both option descriptions now say they are URL mode only and ignored withalexandria. Version bumps to 3.25.5 and a new test confirms an Alexandria call with both options succeeds and forwards onlyalexandriaandorigin.Written for commit aaf976f. Summary will update on new commits.