Skip to content

Accept optional objective and client model in MCP Search - #470

Merged
KrisOei merged 6 commits into
mainfrom
feat/search-task-context
Oct 1, 2026
Merged

KrisOei merged 6 commits into
mainfrom
feat/search-task-context

Conversation

@KrisOei

@KrisOei KrisOei commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Adds optional objective and clientModel fields to MCP Search. Existing calls behave as before.

Requires firecrawl/firecrawl#4881.

Checks

Build, lint, and Search tests passed.

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 3 files

Requires human review: Adds optional objective/sessionId/clientModel to MCP search tools and forwards them to /v2/search. This changes the public MCP request contract and forwards new user-supplied data, and relies on an external v2 API PR for field support.

Fix all with cubic | Re-trigger cubic

Comment thread docs/search-profile.md Outdated
Comment thread src/index.ts Outdated

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0 issues found across 2 files (changes from recent commits).

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Requires human review: Adds optional objective/sessionId/clientModel fields to MCP search tools and forwards them to /v2/search on both the primary and full surfaces. This changes the public MCP tool input contract and the full-profile tool's accepted/forwarded fields, so human sign-off is required.

Re-trigger cubic

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0 issues found across 3 files (changes from recent commits).

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Requires human review: Adds optional objective/clientModel to MCP search tools and forwards them to /v2/search on both strict and full firecrawl_search surfaces; this public contract and data-exposure change needs human sign-off.

Re-trigger cubic

@capy-ai capy-ai Bot changed the title feat(search): expose optional task context in MCP tools Accept optional objective in MCP Search Oct 1, 2026

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0 issues found across 3 files (changes from recent commits).

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Requires human review: Adds an optional objective field to both strict and full firecrawl_search MCP tools and forwards it to /v2/search; this public tool-contract and data-exposure change needs human sign-off.

Re-trigger cubic

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0 issues found across 1 file (changes from recent commits).

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Requires human review: Adds an optional objective to the MCP search tool and forwards it to /v2/search on both strict and full surfaces; this public tool-contract and task-context data-exposure change still needs human sign-off, and the dismissed finding remains applicable.

Re-trigger cubic

@capy-ai capy-ai Bot changed the title Accept optional objective in MCP Search Accept optional objective and client model in MCP Search Oct 1, 2026

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0 issues found across 3 files (changes from recent commits).

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Requires human review: Adds optional objective and clientModel to the public MCP search tool on both strict and full surfaces and forwards them to /v2/search; this expands the public tool contract and task-context data exposure.

Re-trigger cubic

@KrisOei
KrisOei merged commit 8fd1372 into main Oct 1, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant