Repository navigation
fix: make objective optional in Alexandria session feedback - #478
Merged
Merged
Conversation
3.27.1 required objective at runtime while the advertised tool schema marked it optional, so agents that omitted it had their feedback rejected before it reached the API. The API already accepts feedback without an objective. Bump to 3.27.3. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Alexandria feedback volume dropped from Sept 30. #469 (released in 3.27.1) made
objectiverequired forfirecrawl_feedbackwithendpoint: "alexandria", but only in the runtime refinement (alexandriaSessionFeedbackSchema). The advertised tool schema still marksobjectiveoptional, so models often omit it and the call fails parameter validation before anything reaches the API. The API (firecrawl/firecrawl#4877) deliberately accepts feedback without an objective.Change
objectiverequirement fromalexandriaSessionFeedbackSchema; it stays optional, still validated as non-blank when present, and still listed in the tool description andfeedbackToolhint.objectiveis forwarded (without the field); a blankobjectiveis still rejected.Testing
node --test tests/mcp-smoke.test.mjs tests/mcp-alexandria-feedback-hints.test.mjs: 60/60 pass.After merge, the hosted MCP needs a redeploy for the fix to reach hosted users.
Made with Cursor
Summary by cubic
Fixes Alexandria session feedback being rejected when models omit
objective. 3.27.1 required it at runtime while the advertised tool schema marked it optional, so calls failed validation before reaching the API, which already accepts feedback without an objective.objectiveis now optional at runtime, matching the advertised schema, and is still rejected when blank. Bumps to 3.27.3; the hosted MCP needs a redeploy.Written for commit 573bed6. Summary will update on new commits.