Repository navigation
fix(api): unblock provider terms review and link to data source settings - #4673
Closed
developersdigest wants to merge 1 commit into
Closed
developersdigest wants to merge 1 commit into
developersdigest wants to merge 1 commit into
Conversation
This was referenced Sep 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Authenticated teams without
exchangeRetrievecurrently receive 403 when the CLI or MCP asks to read provider terms, before a user can review the agreement. Allow the GET provider-terms routes through the authenticated proxy, retaining team identity and existing write/acceptance checks.Terms-required responses now link to the dashboard's existing
/app/settings?tab=data-sourcesacceptance surface instead of provider pages reported to return 404. Provider and version remain in both the structured action and message.Validation
git diff --checkpass.Related: https://github.com/firecrawl/exchange/issues/563 and https://github.com/firecrawl/exchange/issues/540.
Client follow-ups: firecrawl/cli#246 and firecrawl/firecrawl-mcp-server#405.
Summary by cubic
Unblocks provider terms review for authenticated teams without
exchangeRetrieve, so CLI and MCP users can read terms before accepting. Terms-required responses now link to/app/settings?tab=data-sourcesinstead of provider pages that return 404.Bug Fixes
/provider-termsroutes now proxy withrequiresRetrieveFlag: false, keeping team identity; POST accept/events routes keep the existing flag and org/authority checks.firecrawl/exchange#563andfirecrawl/exchange#540; client follow-ups infirecrawl/cli#246andfirecrawl/firecrawl-mcp-server#405.Written for commit e59d286. Summary will update on new commits.