[BFP-4065] pro sdk add client to jwt token#269
Merged
Conversation
NidaKarim
requested review from
a team,
alawrenc and
lucasfronza
as code owners
nikita-seedlabs
previously approved these changes
Mar 10, 2026
Contributor
|
we'd want to generate the clients for this as well |
NidaKarim
changed the title
kevin-ip
reviewed
Mar 11, 2026
| get: | ||
| tags: | ||
| - Auth | ||
| summary: /auth/zklogin |
Contributor
There was a problem hiding this comment.
Could you keep the summary? for we need it on README.com
resources/auth-api.yaml
Outdated
| get: | ||
| tags: | ||
| - Auth | ||
| description: OpenID Connect Discovery endpoint |
Contributor
There was a problem hiding this comment.
Could you help add the following for readme.com:
Suggested change
| description: OpenID Connect Discovery endpoint | |
| summary: /.well-known/openid-configuration | |
| description: OpenID Connect Discovery endpoint |
resources/auth-api.yaml
Outdated
| tags: | ||
| - Auth | ||
| summary: /auth/zklogin/zkp | ||
| summary: ZK Login Zero-Knowledge Proof Proxy Endpoint |
Contributor
There was a problem hiding this comment.
Suggested change
| summary: ZK Login Zero-Knowledge Proof Proxy Endpoint | |
| summary: /auth/zklogin/zkp |
resources/auth-api.yaml
Outdated
| post: | ||
| tags: | ||
| - Auth | ||
| description: 'OAuth2 client_credentials grant for service accounts' |
Contributor
There was a problem hiding this comment.
Suggested change
| description: 'OAuth2 client_credentials grant for service accounts' | |
| summary: /auth/client-credentials | |
| description: 'OAuth2 client_credentials grant for service accounts' |
| get: | ||
| tags: | ||
| - Auth | ||
| summary: "Internal use only for private launch; Will be removed when we go fully live" |
Contributor
There was a problem hiding this comment.
We may need to do something to hide it on README.com
resources/common.yaml
Outdated
Comment on lines
+242
to
+243
| client: | ||
| $ref: './auth-api.yaml#/components/schemas/ClientType' |
Contributor
There was a problem hiding this comment.
Can we hoist the schemas/ClientType over to common.yaml? so that all the services wouldn't need to depend on auth-api.yaml
nikita-seedlabs
approved these changes
Mar 11, 2026
kevin-ip
reviewed
Mar 11, 2026
| components: | ||
| schemas: | ||
| # enums, please sort it in alphabetical order | ||
| ClientType: |
Contributor
There was a problem hiding this comment.
Friendly reminder to backport the changes to the monorepo.
kevin-ip
reviewed
Mar 11, 2026
| in: query | ||
| required: false | ||
| schema: | ||
| $ref: '#/components/schemas/ClientType' |
Contributor
There was a problem hiding this comment.
Should we reference the ClientType from common.yaml?
Suggested change
| $ref: '#/components/schemas/ClientType' | |
| $ref: '"./common.yaml#/components/schemas/ClientType' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.