fix: remove unused flask dependency from requirements.txt#371
Open
abhishek-8081 wants to merge 1 commit intofireform-core:mainfrom
Open
fix: remove unused flask dependency from requirements.txt#371abhishek-8081 wants to merge 1 commit intofireform-core:mainfrom
abhishek-8081 wants to merge 1 commit intofireform-core:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removed
flaskfromrequirements.txt— it's not imported anywhere in the codebase.Why
The API is built entirely on FastAPI + Uvicorn.
flaskappears to be a leftover from the original hackathon version. Having it listed alongsidefastapiis confusing for new contributors, and it pulls in unnecessary sub-dependencies (Werkzeug, Jinja2, MarkupSafe, etc.) that bloat the Docker image.Verification
grep -r "flask" --include="*.py" .from the project root → zero matchesapi/main.pyusesfrom fastapi import FastAPIFixes #370