Add validation for input_text in fill_form endpoint#377
Open
Lochit-Vinay wants to merge 2 commits intofireform-core:mainfrom
Open
Add validation for input_text in fill_form endpoint#377Lochit-Vinay wants to merge 2 commits intofireform-core:mainfrom
Lochit-Vinay wants to merge 2 commits intofireform-core:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #376
Summary
Added validation for
input_textin thefill_formendpoint to prevent empty or whitespace-only input.Problem
The endpoint allowed empty or whitespace-only
input_text, which could lead to:Before
Solution
Added input validation at the beginning of the function:
After
Benefits