Refactor: move input_text validation to schema level using Pydantic validators#379
Open
Lochit-Vinay wants to merge 3 commits intofireform-core:mainfrom
Open
Refactor: move input_text validation to schema level using Pydantic validators#379Lochit-Vinay wants to merge 3 commits intofireform-core:mainfrom
Lochit-Vinay wants to merge 3 commits intofireform-core:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #378
Summary
Moved input validation for
input_textfrom the endpoint to the schema level using Pydantic validators.Problem
Validation was previously handled inside the route, leading to scattered and non-reusable logic.
Before
Validation was implemented inside the endpoint:
After
Validation is now centralized in the schema:
Solution
Added a field validator in the
FormFillschema and removed manual validation from the route.Benefits