Skip to content

fix: add pull-model to make fireform so Mistral is pulled during setup#383

Open
abhishek-8081 wants to merge 1 commit intofireform-core:mainfrom
abhishek-8081:fix/make-fireform-pull-model
Open

fix: add pull-model to make fireform so Mistral is pulled during setup#383
abhishek-8081 wants to merge 1 commit intofireform-core:mainfrom
abhishek-8081:fix/make-fireform-pull-model

Conversation

@abhishek-8081
Copy link
Copy Markdown

Title:

fix: add pull-model to make fireform target

Body:

## What

Added `pull-model` as a dependency to the `fireform` Makefile target so the Mistral model gets pulled automatically during setup.

## Why

`make fireform` is listed as the primary setup command in `make help`, but it only ran [build](cci:1://file:///Users/abhishekkumar/FireForm/src/llm.py:25:4-44:21) and `up` without pulling the model. Running `python3 src/main.py` after setup would hang and fail because Mistral was not available.

`container-init.sh` already includes `make pull-model` in its flow, so this just brings `make fireform` in line with that.

## Changes

```diff
-fireform: build up
+fireform: build up pull-model

Testing

  • Verified the dependency chain: build -> up -> pull-model -> shell
  • Confirmed container-init.sh uses the same sequence

Fixes #382

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG]: make fireform doesn't pull the Mistral model — setup fails silently depending on which path you follow

1 participant