fix: import Union in main.py and correct pytest directory in Makefile#407
Open
Dotify71 wants to merge 2 commits intofireform-core:mainfrom
Open
fix: import Union in main.py and correct pytest directory in Makefile#407Dotify71 wants to merge 2 commits intofireform-core:mainfrom
Dotify71 wants to merge 2 commits intofireform-core:mainfrom
Conversation
added 2 commits
March 31, 2026 23:51
Implemented PDF /Btn dictionary parsing in filler.py to extract and dynamically map truthy LLM outputs to their specific 'ON' Appearance Mode instead of blindly appending strings. Also resolved broken backend pipeline in main.py by initializing the base Controller instead of the removed Fill class.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes two priority issues:
Unionimport insrc/main.pywhich was causing a NameError on startup.Makefilefromsrc/test/totests/so the test suite runs correctly.Additionally, this PR implements Checkboxes and Radio Button Mapping (Deliverable 1 from my GSoC Proposal).
Advanced PDF Form Mapping (
src/filler.py)filler.pyindiscriminately assigned the LLM string output to the Value (/V) property of all Widget types. This breaks when a PDF contains checkboxes or radio buttons (Field Type/Btn).sorted_annots:/Btn).yes,true,1,x).ONstate identifier directly from the PDF Appearance Dictionary (annot.AP.N)./V) and Appearance State (/AS) to accurately check the box on the final PDF layout, while assigning/Offwhen falsy.Additional Notes for Mentors
While I'm incredibly sad that a time zone miscalculation caused me to miss the official GSoC portal deadline earlier tonight, I remain deeply passionate about FireForm. I wanted to execute this core feature from my proposal anyway to prove its viability and test my own skills. I plan to continue contributing to this repository as an active community member going forward!