Repository navigation
Polish the composer and hold-to-react gestures - #48
Merged
Merged
Conversation
fireplacechat-com
previously approved these changes
Nov 10, 2026
fireplacechat-com
marked this pull request as ready for review
November 10, 2026 04:17
fireplacechat-com
dismissed
their stale review
November 10, 2026 04:19
The merge-base changed after approval.
fireplacechat-com
force-pushed
the
feat/message-composer-polish
branch
2 times, most recently
from
November 10, 2026 04:22
a999780 to
297323b
Compare
…ence Use a rounded input and themed circular send button. Retain the initiating pointer for drag-to-react, restore focus on dismissal, and revoke stale message actions after deletion. Co-authored-by: Codex <noreply@openai.com>
Fit seven accessible buttons within the phone layout and verify the last button without scrolling. Co-authored-by: Codex <noreply@openai.com>
Keep the full touch target within the message row while reducing the detached gap. Verify placement and selection interactions. Co-authored-by: Codex <noreply@openai.com>
Render pictographs at icon size inside full touch targets and cover the enlarged-text interaction. Co-authored-by: Codex <noreply@openai.com>
Include renders for the stacked drafts, reproducibility hashes, protocol and rules checks, and AI assistance disclosure. Co-authored-by: Codex <noreply@openai.com>
fireplacechat-com
force-pushed
the
feat/message-composer-polish
branch
from
November 10, 2026 04:26
297323b to
8a97446
Compare
fireplacechat-com
approved these changes
Nov 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The text composer and held-message gestures should feel consistent with the requested Signal iOS reference while keeping Fireplace's theme.
What changed
Use a rounded text input and a themed circular send button, with multiline editing and existing limits preserved. Keep the initiating pointer active so holding, sliding to an emoji and releasing performs the reaction. Restore focus after dismissal, dismiss with Back/Escape, and revoke content actions if a remote deletion arrives while the menu is open. Fit the expanded-picker button visibly in the quick reaction strip, attach reaction pills to the bubble edge, and keep picker emoji legible with enlarged text.
Includes review screenshots for all four stacked drafts. No attachments, authentication/settings changes or additional protocol changes in this draft. This implements the requested context-menu, selection, reactions, deletion and composer scope; it does not claim parity with every Signal feature.
How it was checked
See the review report for fresh-checkout validation, protocol/rules tests and render reproducibility. New tests cover composer shape/theme/multiline sending, focus, held-pointer reaction, picker visibility and live deletion. No physical device testing. Stacked on encrypted controls.
AI assistance
OpenAI Codex wrote the implementation, tests and review notes. Human review and CLA confirmation are pending; this draft does not assert a human has approved or understood the changes.
Privacy
No new data or server fields beyond the encrypted controls in the parent draft. Fixtures are fictional. Render font fallback is test-only and not bundled.