Add multi-artist search fallback - #207
Conversation
JustinPerlman
left a comment
There was a problem hiding this comment.
Hmm... still seeing issues with songs where the name of the song is also the album title. Pretty common for singles (album has one song it and the the song and album are named the same)
Examples:
Knock2 nolimit (not a single but the album has the same name)
Henry Fong;Knock2;General Degree - What's the Move (feat. General Degree) (single)
JustinPerlman
left a comment
There was a problem hiding this comment.
Knock2;Warren Hue;Holly;PIAO - shyne 4 me (feat. PIAO)
John Summit;Sub Focus;Julia Church - Go Back (feat. Julia Church)
ISOxo;Knock2 - Beam (Knock2 Remix)
John Summit;Kaskade;Julia Church - Resonate (feat. Julia Church)
John Summit;Echoes;Aaron Hibell - Human (feat. Echoes) - Aaron Hibell Remix
These all failed as well. These examples point to a second shared failure: the fallback artist query still includes the featured-artist text in the title, so it asks Soulseek to match every token, including names that may not appear in the shared filename.
|
I agree on fallbacks but I'd rather solve this as a more coherent fallback strategy than bolt on special cases to We already have
(These should be cumulative, I can't think of a reason you'd want level 2/3 without trying the cheaper and more specific level 1 first.) That addresses both the original multi-artist issue and the The only problem with extracting the artist is of course that we will inevitably run into cases where artist names themselves contain commas and ampersands (chatgpt gave I also don't think Implementation-wise, I'd prefer some kind of a small search-attempt planner that generates ordered variants (network query + attempt-specific matching/condition overrides), dedupes equivalent attempts, and executes them up to the configured level. Aside from that, there is still the question of what we should do for result ranking. |
Fixes #206
Summary
Tests