Skip to content

fix: improve editable-element detection and increase safe operation timeout #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
eduardofcr wants to merge 1 commit into from
Closed

fix: improve editable-element detection and increase safe operation timeout #85

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion extensions/agent-browser/lib/process.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ const AGENT_BROWSER_SOCKET_DIR_ENV = "AGENT_BROWSER_SOCKET_DIR";
const AGENT_BROWSER_DEFAULT_TIMEOUT_ENV = "AGENT_BROWSER_DEFAULT_TIMEOUT";
const PI_AGENT_BROWSER_PROCESS_TIMEOUT_ENV = "PI_AGENT_BROWSER_PROCESS_TIMEOUT_MS";
const DEFAULT_AGENT_BROWSER_SOCKET_DIR_PREFIX = "/tmp/piab";
export const SAFE_AGENT_BROWSER_OPERATION_TIMEOUT_MS = 25_000;
export const SAFE_AGENT_BROWSER_OPERATION_TIMEOUT_MS = 35_000;
const DEFAULT_AGENT_BROWSER_PROCESS_TIMEOUT_MS = 35_000;
/** Grace period after `exit` before resolving when `close` is delayed by inherited stdio handles. */
const EXIT_STDIO_GRACE_MS = 100;
Expand Down
8 changes: 8 additions & 0 deletions extensions/agent-browser/lib/results/editable-ref-evidence.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,9 @@ const EDITABLE_FALSE_TEXT_PATTERN = /\b(?:contenteditable|editable)\s*=\s*["']?(
const EDITABLE_ASSIGNMENT_TEXT_PATTERN = /\b(contenteditable|editable)\s*=\s*("[^"]*"|'[^']*'|[^\s,\]]+)/gi;
const EDITABLE_BARE_TEXT_PATTERN = /\b(?:contenteditable|editable)\b(?!\s*=)/i;

/** Roles that are inherently editable controls in the browser accessibility tree. */
const KNOWN_EDITABLE_ROLES = new Set(["searchbox", "textbox", "combobox", "spinbutton"]);

function parseEditableEvidenceValue(value: unknown): boolean | undefined {
if (typeof value === "boolean") return value;
if (typeof value === "number") {
Expand Down Expand Up @@ -61,6 +64,11 @@ export function getEditableRefEvidence(options: {
const textEvidence = parseEditableEvidenceText(options.text);
if (textEvidence === false) return false;
if (textEvidence === true) hasPositiveEvidence = true;
// Fallback: treat inherently editable ARIA roles as editable even when
// upstream snapshot metadata does not include explicit editable flags.
if (!hasPositiveEvidence && options.ref?.role && KNOWN_EDITABLE_ROLES.has((options.ref.role as string).toLowerCase())) {
hasPositiveEvidence = true;
}
return hasPositiveEvidence ? true : undefined;
}

Expand Down