Code Modernization and Type Hinting#32
Open
bmos wants to merge 13 commits into
Open
Conversation
b6d72f0 to
f319fe4
Compare
3c639b2 to
a541123
Compare
…, improved error formatting, don't close open file)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
General modernization, since the package was originally built to be compatible with python 2.
The major benefit here is the type hinting, especially in reference to the string literals.
With this sort of type hinting in place, most IDEs will highlight code issues before the user even runs it. It's a big improvement to ease of use.
A couple of the other improvements that are worth noting:
raise from, which makes error messages more helpfuladdressbatchno longer closes file-like (already open) objects, only files that it opensaddressbatchnow accepts Path objects too, not just str paths