馃 Automatic code style fixes - #5
Open
github-actions[bot] wants to merge 1 commit into
Open
Conversation
fiwswe
pushed a commit
that referenced
this pull request
Jul 21, 2026
* added docs about running tests on 32bit w/ podman. * Updated tests to use string instead of int for comparison when 32bit. * added `make_bitmask_32` and `bitmask64_32`. updated `ipInRange` to use them. Test failing for `test_ip_to_number` ``` podman run -v $PWD/..:/dokuwiki \ --workdir /dokuwiki/_test -it \ docker://wpstaging/php:8.3-32bit \ ./vendor/bin/phpunit --verbose --stderr --filter ip_test ``` ``` 1) ip_test::test_ip_to_number with data set #3 ('38AF:3033:AA39:CDE3:1A46:094C...D:5300', 6, 4.084536385505709E+18, 1.8932109165344407E+18) Failed asserting that two strings are identical. --- Expected +++ Actual @@ @@ -'4084536385505709056' +'4084536381210742243' /dokuwiki/_test/tests/inc/Ip.test.php:52 2) ip_test::test_ip_to_number with data set #5 ('193.53.125.7', 4, 0, 3241508103) Failed asserting that -1053459193 is identical to 3241508103. ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes were made automatically by running rector and phpcbf.
Please carefully check the changes before merging. Please note that unit tests are not run for automated pull requests - so if in doubt, manually test the branch before merging.
If you disagree with the changes, simply clean the code yourself and create a new pull request. This PR automatically closes when no more changes are suggested by rector and phpcbf.